You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Bumped into this while trying to port this over to TensorKit:
Other parts of the code use ind = Colon() as default, and then first take indV = axes(V, 2)[ind] before doing the check of the length (length(ind) fails if ind = Colon()).
Here I just did the same.
I checked for the SVD gauge removal and was surprised that there is no ind argument there, @Jutho is this meant to be like this?
Let me continue on this PR, there are some more inconsistencies in how ind is treated also in the eig and eigh pullbacks. This should perhaps have been part of the previous PR, but it got merged quickly to fix the svd_full case. I will also switch over the eig and eigh pullbacks to this prepare_and_check_cotangents format, and at an ind argument in the remove_svd_gauge_dependence .
Upon some consideration, I think it is actually easier to remove the ind argument in the remove_x_gauge_dependence! functions. I think in these functions it is fine to assume that the V and ΔV passed in have the same number of columns. The ind is mostly an internal implementation detail that needs to be intercepted for TruncatedAlgorithm decompositions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumped into this while trying to port this over to TensorKit:
Other parts of the code use
ind = Colon()as default, and then first takeindV = axes(V, 2)[ind]before doing the check of the length (length(ind)fails ifind = Colon()).Here I just did the same.
I checked for the SVD gauge removal and was surprised that there is no
indargument there, @Jutho is this meant to be like this?